Hello Hsuan Ting Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45465
to review the following change.
Change subject: libpayload: free: Separate NULL check out for clarity ......................................................................
libpayload: free: Separate NULL check out for clarity
Separate the validity check of calling free(NULL) for clarity.
BUG=b:168441735 TEST=emerge-puff libpayload
Change-Id: I0dc355553410bbe59e658945fb40c05f5f709380 Signed-off-by: Hsuan Ting Chen roccochen@chromium.org --- M payloads/libpayload/libc/malloc.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/45465/1
diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 48bf32e..20f9ef3 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -246,6 +246,10 @@ hdrtype_t hdr; struct memory_type *type = heap;
+ /* No action occurs on NULL. */ + if (ptr == NULL) + return; + /* Sanity check. */ if (ptr < type->start || ptr >= type->end) { type = dma;