Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )
Change subject: src/superio/nuvoton/nct5104d: assign IO port range to control GPIO
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35849/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35849/1//COMMIT_MSG@7
PS1, Line 7: src/superio/nuvoton/nct5104d: assign IO port range to control GPIO
Please remove `src/` from the prefix.
https://review.coreboot.org/c/coreboot/+/35849/1//COMMIT_MSG@10
PS1, Line 10: to I/O register, now.
Now, Super I/O GPIOs can also be controlled directly through access to I/O registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ce99bb44e6f5db684170f4190bdc38a944849f6
Gerrit-Change-Number: 35849
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 14:06:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment