[coreboot-gerrit] [S] Change in coreboot[main]: soc/mediatek/mt8196: Add booker driver

[Jarried Lin (Code Review)]

Attention is currently required from: Dehui Sun, Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )

Change subject: soc/mediatek/mt8196: Add booker driver
......................................................................

Patch Set 10:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85362/comment/7097422e_64333d43?usp... :
PS9, Line 9: The MTK booker
> Okay, This will be modified in the next release.

Done

https://review.coreboot.org/c/coreboot/+/85362/comment/f4b319e2_05a7fcd4?usp... :
PS9, Line 15: it can
> Okay, This will be modified in the next release.

Done

https://review.coreboot.org/c/coreboot/+/85362/comment/cfe2f5f6_c55f07d6?usp... :
PS9, Line 15: it can
            : set bit[3] (disable_cmo_prop) to 0 in the por_sbsx_cfg_ctl register of
            : each SBSX node.
> Yes, the default value of the reg por_sbsx_cfg_ctl is 64'b1111111, we must clear bit3 to 0.

Done

File src/soc/mediatek/mt8196/booker.c:

https://review.coreboot.org/c/coreboot/+/85362/comment/5056964e_0f3b047b?usp... :
PS9, Line 11: MCUSYS_PAR_WRAP_BASE
> Okay, This will be modified in the next release.

Done

https://review.coreboot.org/c/coreboot/+/85362/comment/6115391e_9574db0d?usp... :
PS9, Line 13: 0x00450000 + 0x0A00
> Okay, This will be modified in the next release.

Done