Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39470 )
Change subject: soc/intel/tigerlake: Publish single GPIO ACPI device for Jasper Lake
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Looks good overall, especially given that we are planning to split Jasper Lake as a separate SoC. Please address the nits.
https://review.coreboot.org/c/coreboot/+/39470/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39470/5//COMMIT_MSG@9
PS5, Line 9: Pin-Ctrl
Nit: pin-ctrl
https://review.coreboot.org/c/coreboot/+/39470/5//COMMIT_MSG@10
PS5, Line 10: in
Nit: is
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc92adaee550182ab405541ea85019f31bb8658
Gerrit-Change-Number: 39470
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Mar 2020 19:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment