Attention is currently required from: Sean Rhodes, Martin Roth, Matt DeVillier, Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59256 )
Change subject: util: Add coreboot-configurator ......................................................................
Patch Set 8:
(108 comments)
File util/coreboot-configurator/src/README.md:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7d78b40c_a8bcbb7e PS8, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/AboutDialog.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9b818a52_c6513f29 PS8, Line 13: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/bd6b1833_de810609 PS8, Line 15: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/14073f49_0a91659f PS8, Line 16: explicit AboutDialog(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/76af28a2_81cf6552 PS8, Line 16: explicit AboutDialog(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/75fb7261_b6cfce6b PS8, Line 17: ~AboutDialog(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9184266f_294c97cd PS8, Line 20: Ui::AboutDialog *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cd45c66e_ef761517 PS8, Line 20: Ui::AboutDialog *ui; labels should not be indented
File util/coreboot-configurator/src/application/Configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ae281576_977dcd7f PS8, Line 13: using Parameters = QMap<QString,QString>; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/681869cc_7d2c1ec2 PS8, Line 13: using Parameters = QMap<QString,QString>; space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b5a31a62_b6c8fd4b PS8, Line 13: using Parameters = QMap<QString,QString>; spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b29bb01e_f36530ed PS8, Line 15: Parameters fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/1259b653_ccdbc1a2 PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/040980d2_12040f7d PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3bf96875_4c1ffbe9 PS8, Line 16: bool toFile(const QString& curr_path, const Parameters& params); function definition argument 'const Parameters' should also have an identifier name
File util/coreboot-configurator/src/application/MainWindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6c627ecd_d7c49bb0 PS8, Line 19: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/f14c0c6b_c35a0f33 PS8, Line 21: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/fabdb8e5_a3de20a0 PS8, Line 22: MainWindow(QWidget *parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/77f9c8ea_c061ff53 PS8, Line 22: MainWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/84c55720_0797f07e PS8, Line 23: ~MainWindow(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a558c9e1_2ae4e5c7 PS8, Line 26: void updateValue(const QString& key); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/b793de77_9b89b9cc PS8, Line 26: void updateValue(const QString& key); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ff9ac612_f7cce52c PS8, Line 29: void on_actionSave_triggered(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/25d0687e_08bc7b8c PS8, Line 29: void on_actionSave_triggered(); Bad function definition - void on_actionSave_triggered() should probably be void on_actionSave_triggered(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7536ab88_431e3f39 PS8, Line 31: void on_actionLoad_triggered(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/889471da_74c0c864 PS8, Line 31: void on_actionLoad_triggered(); Bad function definition - void on_actionLoad_triggered() should probably be void on_actionLoad_triggered(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/63cb023a_f52331ea PS8, Line 33: void on_saveButton_clicked(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/082840ef_4d93a3a0 PS8, Line 33: void on_saveButton_clicked(); Bad function definition - void on_saveButton_clicked() should probably be void on_saveButton_clicked(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/462b4885_48ff535b PS8, Line 36: void pullSettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2dc2cb2f_45bdb4ce PS8, Line 36: void pullSettings(); Bad function definition - void pullSettings() should probably be void pullSettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3ad5580c_5ffc405c PS8, Line 37: void pushSettings(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8cbcd98e_0c45acc6 PS8, Line 37: void pushSettings(); Bad function definition - void pushSettings() should probably be void pushSettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/97f5771a_e3e146d2 PS8, Line 39: void generateUi(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/991fe9da_bc2ed9ba PS8, Line 39: void generateUi(); Bad function definition - void generateUi() should probably be void generateUi(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2e3214c8_fd5cd789 PS8, Line 40: void askForReboot(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/74aba5a0_5a1846f8 PS8, Line 40: void askForReboot(); Bad function definition - void askForReboot() should probably be void askForReboot(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6cf1f063_fb84bf37 PS8, Line 42: void readSettings(const QString& fileName); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8c93d81e_657951c9 PS8, Line 42: void readSettings(const QString& fileName); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/5fdb0f38_a6123d37 PS8, Line 43: void writeSettings(const QString& fileName); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/c51e49a6_006b6709 PS8, Line 43: void writeSettings(const QString& fileName); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/17aa73f9_c4d94965 PS8, Line 45: Configuration::Parameters m_parameters; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/fb118726_915ea134 PS8, Line 46: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/79d6159d_0d6eaffe PS8, Line 48: Ui::MainWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/895178cb_880f6c8b PS8, Line 48: Ui::MainWindow *ui; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/afa10dc6_22e76f36 PS8, Line 50: QComboBox *createComboBox(const QString &key); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a32a92b7_a2edf7ec PS8, Line 50: QComboBox *createComboBox(const QString &key); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/887d2129_02c56b69 PS8, Line 51: QCheckBox *createCheckBox(const QString &key); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2676299e_e9c003da PS8, Line 51: QCheckBox *createCheckBox(const QString &key); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/baaa018e_561b6113 PS8, Line 53: QTableWidget *createRawTable(); please, no spaces at the start of a line
File util/coreboot-configurator/src/application/MainWindow.cpp:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/23ba0131_cfbf913e PS8, Line 17: static auto s_errorWindowTitle = MainWindow::tr("Error Occured"); 'Occured' may be misspelled - perhaps 'Occurred'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/935353fd_54f4f8a2 PS8, Line 355: QMessageBox::critical(this, tr("Error Occured"), tr("Can't open file to write")); 'Occured' may be misspelled - perhaps 'Occurred'?
File util/coreboot-configurator/src/application/NvramToolCli.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cb00a120_27c70042 PS8, Line 12: * Namespace for convinient functions to work with nvramtool CLI utility 'convinient' may be misspelled - perhaps 'convenient'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ba383a85_0e6d47f8 PS8, Line 16: Configuration::Parameters readParameters(QString* error = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/dcff08bb_0528c8dc PS8, Line 17: QStringList readOptions(const QString& parameter, QString* error = nullptr); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e23bc161_1648b0cc PS8, Line 17: QStringList readOptions(const QString& parameter, QString* error = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/0ddf2909_0f69b3d7 PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2d261f75_2e48795d PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/85313b37_e8417381 PS8, Line 18: bool writeParameters(const Configuration::Parameters& parameters, QString* error = nullptr); function definition argument 'Parameters' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3da589b2_678bdea8 PS8, Line 19: QString version(); Bad function definition - QString version() should probably be QString version(void)
File util/coreboot-configurator/src/application/ToggleSwitch.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/3eac1c76_80ab09a6 PS8, Line 12: * The ToggleSwitch class represents Toggle Switch widget based on QCheckBox and toggles svg with colorscheme support line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/de4540ca_1cdf2716 PS8, Line 15: Q_OBJECT please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/eda8eaf3_e7bfa123 PS8, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/87238e23_2f2e2738 PS8, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/84c8ac2c_e1e617d9 PS8, Line 17: explicit ToggleSwitch(QWidget* parent = nullptr); need consistent spacing around '*' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/eaec35ea_64691db2 PS8, Line 20: QSvgRenderer m_svgr; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e403afa8_8cfe7b29 PS8, Line 22: static const QByteArray s_toggleOnSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/277f1b7b_b30a7866 PS8, Line 23: static const QByteArray s_toggleOffSvgContent; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/99a2dcbb_1db125e9 PS8, Line 24: static const int s_colorPosInToggleOn; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a9868fc5_c879b37c PS8, Line 26: QByteArray m_toggleOnSvgContentColored; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a8232df8_b0cb3a2b PS8, Line 30: void paintEvent(QPaintEvent *event) override; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d64286de_ad872d63 PS8, Line 30: void paintEvent(QPaintEvent *event) override; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6d4a806b_3bc7de0f PS8, Line 34: bool hitButton(const QPoint &pos) const override please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7d141306_c52224b8 PS8, Line 34: bool hitButton(const QPoint &pos) const override need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/a0060211_3f6db550 PS8, Line 35: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/06bf9bda_2458f7c3 PS8, Line 36: /* needs to be clickable on */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/06a86fea_7a50df3b PS8, Line 37: return rect().contains(pos); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d5cf4922_f5f46009 PS8, Line 37: return rect().contains(pos); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/46c96531_36e1eaa9 PS8, Line 38: } please, no spaces at the start of a line
File util/coreboot-configurator/src/application/Util.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/d9d0ee7f_e867a18e PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/541fca4e_d11847f0 PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e03010ed_64d260f5 PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9c26fe15_adf8e62b PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/955cb995_fb8c1c9a PS8, Line 11: inline QMap<QString,QString> parseParameters(QIODevice& dev){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ef47092c_3a8cd142 PS8, Line 12: QString curr_line; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e651500e_d3d427d8 PS8, Line 13: QMap<QString, QString> result; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/93204019_b0d7264c PS8, Line 13: QMap<QString, QString> result; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/9d7b185e_27e6730b PS8, Line 13: QMap<QString, QString> result; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ca78804e_1eb89c9a PS8, Line 15: while (!dev.atEnd()) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/cd72861f_1b03b526 PS8, Line 16: curr_line = dev.readLine().trimmed(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/77a2168e_0ecd1ddd PS8, Line 16: curr_line = dev.readLine().trimmed(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e8f91578_21b73e3f PS8, Line 18: auto split = curr_line.split('='); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/0f36371e_071ff477 PS8, Line 18: auto split = curr_line.split('='); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2fb4a9c5_1739666e PS8, Line 19: if(split.size()!=2){ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8d6ba755_7f46bf02 PS8, Line 19: if(split.size()!=2){ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/4fe9d2a3_d00f426b PS8, Line 19: if(split.size()!=2){ suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/8318a453_5c924d7f PS8, Line 19: if(split.size()!=2){ spaces required around that '!=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e18748b1_4493b396 PS8, Line 19: if(split.size()!=2){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2e178636_63afeb10 PS8, Line 19: if(split.size()!=2){ space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/2b2738d1_90a2db42 PS8, Line 19: if(split.size()!=2){ braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/db64af76_dba6ded9 PS8, Line 20: continue; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/27c91d03_2e7a22f3 PS8, Line 20: continue; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/6ace55cd_51235e94 PS8, Line 21: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/19d45384_7237b3b3 PS8, Line 21: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/24a415c5_4b8126a5 PS8, Line 23: result.insert(split[0].trimmed(), split[1].trimmed()); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/ab46093d_f504cd31 PS8, Line 23: result.insert(split[0].trimmed(), split[1].trimmed()); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/00262586_a81621ad PS8, Line 24: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/e2db14a9_1dfe2f8d PS8, Line 25: return result; please, no spaces at the start of a line
File util/coreboot-configurator/src/application/qrc/categories.yaml:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133701): https://review.coreboot.org/c/coreboot/+/59256/comment/7fa6660b_ad0a1c21 PS8, Line 84: help: Adjust the amout of time before the keyboard backlight turns off when un-used 'amout' may be misspelled - perhaps 'amount'?