Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Meera Ravindranath, Patrick Rudolph, EricR Lai. Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Meera Ravindranath, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60774
to look at the new patch set (#5).
Change subject: soc/intel/common/gpio: Rework PAD config macro to add lock support ......................................................................
soc/intel/common/gpio: Rework PAD config macro to add lock support
This patch creates new GPIO PAD configuration macros that would help to perform GPIO pad configuration and pad lock configuration as well.
Lists of new macros are: 1. PAD_CFG_NF_LOCK 2. PAD_CFG_GPO_LOCK 3. PAD_CFG_GPI_LOCK 4. PAD_CFG_GPI_TRIG_OWN_LOCK 5. PAD_CFG_GPI_GPIO_DRIVER_LOCK 6. PAD_CFG_GPI_INT_LOCK 7. PAD_CFG_GPI_APIC_LOCK 8. PAD_CFG_GPI_IRQ_WAKE_LOCK
Mainboard users can use the above macros to lock the PAD after configuration.
So far on IA chipset. the default GPIO pad lock configuration reset type is POWERGOOD hence, its recommended as per GPIO BWG (doc: 630603) to configure the GPP PAD reset type as same as lock configuration reset type to avoid GPP reset value misconfiguration issue.
BUG=b:211573253, b:211950520
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ibf8b0a845005ad545266d995449d0aa711f45a61 --- M src/soc/intel/common/block/gpio/gpio.c M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/include/intelblocks/gpio_defs.h 3 files changed, 81 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60774/5