13 Oct
2020
13 Oct
'20
2:13 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46346 )
Change subject: libpayload/libpci: Add parent pointer to pci_dev ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46346/1/payloads/libpayload/libpci/... File payloads/libpayload/libpci/libpci.c:
https://review.coreboot.org/c/coreboot/+/46346/1/payloads/libpayload/libpci/... PS1, Line 178: dev = dev->next; Code would be clearer if the devices were named differently, but I guess it would also introduce other bugs (using the parent where the child was meant to be used.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46346
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c0aa4f23d4173c09cfc343f657be9eefc8038d1
Gerrit-Change-Number: 46346
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment