Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37921 )
Change subject: mainboard/google/hatch: Move gpio GPP_C* NC down into baseboard
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37921/2/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/37921/2/src/mainboard/google/hatch/...
PS2, Line 170: early_gpio_table
early_gpio_table does not use overrides and so it is necessary to have GPP_C20 in the variant specif […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I578245e24895d361d80ad016a4f18204e2b6e1ca
Gerrit-Change-Number: 37921
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 24 Dec 2019 08:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment