Łukasz Siudut has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31435 )
Change subject: mb/ocp/monolake: fix for booting issues + tmp and ipmi support ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31435/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31435/4//COMMIT_MSG@13 PS4, Line 13: 817994c1bec
Please add the commit message summary in () behind the hash.
Ack
https://review.coreboot.org/#/c/31435/4//COMMIT_MSG@19 PS4, Line 19: - introduced DSDT and SMBIOS entries for IPMI to make it detectable
Please put all of this in separate commits.
Up, up to this descent? When you've been mentioning removing SMBIOS changes I actually though that you are referring to length change in smbios.c. No problem though.
https://review.coreboot.org/#/c/31435/4//COMMIT_MSG@23 PS4, Line 23: why was it there on the first place.
This can be removed now, can it?
Ack