build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46872 )
Change subject: soc/intel/jasperlake: Allow devicetree to fill Emmc tuning params ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 207: params->EmmcTxCmdDelayRegValue = \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 209: params->EmmcTxDataDelay1RegValue = \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 211: params->EmmcTxDataDelay2RegValue = \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 213: params->EmmcRxCmdDataDelay1RegValue = \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 215: params->EmmcRxCmdDataDelay2RegValue = \ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/46872/1/src/soc/intel/jasperlake/fs... PS1, Line 217: params->EmmcRxStrobeDelayRegValue = \ Avoid unnecessary line continuations