Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34616 )
Change subject: soc/intel/cnl: Only print ME status one time ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me... File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/c/coreboot/+/34616/1/src/soc/intel/cannonlake/me... PS1, Line 302:
It gets printed at boot-from-S5, but not from S3 resume in this case. Would we expect the data to change in between?
I believe it is more to ensure that the state can be captured coming out of boot as well as S3 which is generally helpful for debugging in case of failures.
Also, my understanding was that once HECI is disabled, this information is unreliable (?), and that happens when coreboot sends the EndOfFirmware notification, which is at payload load time in the S5 boot path.
EndOfFirmware notification is sent on resume as well:
BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, fsp_notify_dummy, » » » » » » (void *) READY_TO_BOOT);
IIUC, HECI interface needs to be disabled again after resume from S3. +Subrata.