chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44135 )
Change subject: mb/google/zork: C-state IO base address alignment
......................................................................
Patch Set 3:
Patch Set 3:
I think a better approach is to establish that coreboot owns this register and AGESA should leave it alone. So rather than adjust coreboot to match AGESA, how about moving the write of the BSP (in sb_init_acpi_ports()) to model_17_init() to write all cores? I'll push a change for AGESA to skip the register for FSP.
Yes, agree with you. that's better for program MSR only in coreboot or AGESA.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98d34af518439d338326446c20601867ad31690
Gerrit-Change-Number: 44135
Gerrit-PatchSet: 3
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Aug 2020 05:11:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment