[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 29:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... 
PS28, Line 70: TOM1
> I don't see it being used in the kernel code. […]

Yeah, nothing in coreboot seems to be using it as well. There is an External (TOM2) in pci0.asl, but nothing in zork/mandolin using it. I see some old amd mainboards used it. But, probably we can add it when really required?

https://review.coreboot.org/c/coreboot/+/34424/28/src/soc/amd/picasso/northb... 
PS28, Line 75: http://www.acpi.info/presentations/S01USMOBS169_OS%2520new.ppt
> Found one here, but need to sign up... https://www.scribd. […]

Thanks Raul!