[coreboot-gerrit] Change in coreboot[master]: soc/amd/cezanne: add GPIO definitions

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48564 )

Change subject: soc/amd/cezanne: add GPIO definitions
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... 
File src/soc/amd/cezanne/include/soc/gpio.h:

https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... 
PS3, Line 7: GPIO_DEVICE_DESC
nit: Is there any advantage of having a macro for this? It is used in just one place in the ACPI node for GPIO controller. GPIO_DEVICE_NAME gets used by other code as well, so that seems fine.

https://review.coreboot.org/c/coreboot/+/48564/3/src/soc/amd/cezanne/include... 
PS3, Line 282: GPIO_2_EVENT
Why a special macro for GPIO_2 event?