Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46393/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46393/5//COMMIT_MSG@8 PS5, Line 8:
Please elaborate, what DPM is, what it is used for, and where it’s documented.
DPM is used for power manager, which is mediatek proprietary, it's binary release. Sorry for that we can't document it.
https://review.coreboot.org/c/coreboot/+/46393/5//COMMIT_MSG@10 PS5, Line 10: TEST=Boots correctly on Asurada
Tested with what firmware version, and how much time did it add? Maybe add the related coreboot log […]
Dpm is tested pass with firmware 13457.0.
Dpm log is added already, for example: DPM: load finish in 37 msecs