[coreboot-gerrit] Change in coreboot[master]: Revert "soc/intel/cannonlake: Enable ACPI timer emulation if PM timer...

[Michael Niewöhner (Code Review)]

Hello Bora Guvendik, build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Subrata Banik, Aamir Bohra, Aaron Durbin, Patrick Rudolph,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/45000

to review the following change.

Change subject: Revert "soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled"
......................................................................

Revert "soc/intel/cannonlake: Enable ACPI timer emulation if PM timer is disabled"

This reverts commit e5269a8fd975fa0cba0655cd41f7f8cc99a1feb8.

Reason for revert: BIOS spec says, emulation shall be always enabled.

Change-Id: If0d7fa6f9766c7c4e2fa9e846c179adc6a4e1681
---
M src/soc/intel/cannonlake/cpu.c
1 file changed, 1 insertion(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/45000/1

diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index 6682cdc..b0eaa5d 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -384,14 +384,8 @@
  */
 static void enable_pm_timer_emulation(void)
 {
-	const struct soc_intel_cannonlake_config *config;
+	/* ACPI PM timer emulation */
    msr_t msr;
-
-	config = config_of_path(SA_DEVFN_ROOT);
-
-	/* Enable PM timer emulation only if ACPI PM timer is disabled */
-	if (!config->PmTimerDisabled)
-		return;
    /*
     * The derived frequency is calculated as follows:
     *    (CTC_FREQ * msr[63:32]) >> 32 = target frequency.