[coreboot-gerrit] [S] Change in coreboot[main]: util/crossgcc: Add libstdcxx target

[Raul Rangel (Code Review)]

Attention is currently required from: Felix Singer, Jon Murphy, Karthik Ramasubramanian, Martin L Roth.

Raul Rangel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )

Change subject: util/crossgcc: Add libstdcxx target
......................................................................

Patch Set 12:

(4 comments)

File util/crossgcc/buildgcc:

https://review.coreboot.org/c/coreboot/+/85275/comment/e03cad19_3da219ba?usp... :
PS12, Line 840: 		$@
```suggestion
    	"$@"
```

https://review.coreboot.org/c/coreboot/+/85275/comment/e47231c5_55557708?usp... :
PS12, Line 844: 	configure_GCC
The script isn't running with `-e`, so we need to chain the commands.

```suggestion
    configure_GCC && \
```

https://review.coreboot.org/c/coreboot/+/85275/comment/19f4ec2d_b8c942ad?usp... :
PS12, Line 864: 	configure_GCC "--with-gxx-include-dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/"
              : 			--with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/""
```suggestion
    configure_GCC \
    	--with-gxx-include-dir="${LIBSTDCXX_INCLUDE_PATH}/coreboot-${TARGETARCH}/include/" \
    	--with-sysroot="${LIBSTDCXX_INCLUDE_PATH}/" && \
```

https://review.coreboot.org/c/coreboot/+/85275/comment/af2ec73e_2cf529e5?usp... :
PS12, Line 870: || touch .failed 
You don't want to build libstdc++ if libgcc failed.

```suggestion
    $MAKE install-target-libgcc DESTDIR=$DESTDIR && \
```