Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44698 )
Change subject: [WIP] mb/intel/tglrvp: Add support of TPM over SPI
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44698/3/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/44698/3/src/drivers/spi/tpm/tpm.c@1...
PS3, Line 160: udelay(100);
Is this a WIP test patch? You can't just insert random delays into a core driver to work around bugs […]
We removed the delay. Agreed we cannot put delay in common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44698
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4a3aec98f72524e8e2a1834878ef75b9f933ae3e
Gerrit-Change-Number: 44698
Gerrit-PatchSet: 5
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 28 Aug 2020 00:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment