Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80238?usp=email )
Change subject: mb/google/rex/variants/deku: correct GPIO E08 and E22 configuration ......................................................................
mb/google/rex/variants/deku: correct GPIO E08 and E22 configuration
GPP_E08 and GPP_E22 were set incorrectly previously. This CL corrects these settings according to schematics.
BUG=b:305793886 TEST=Built FW image correctly.
Signed-off-by: Eran Mitrani mitrani@google.com Change-Id: I8e427350e1ee564f9d6566bdfe1f42c92c87a711 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80238 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/rex/variants/deku/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/google/rex/variants/deku/gpio.c b/src/mainboard/google/rex/variants/deku/gpio.c index 7648f81..ba5bc17 100644 --- a/src/mainboard/google/rex/variants/deku/gpio.c +++ b/src/mainboard/google/rex/variants/deku/gpio.c @@ -206,8 +206,8 @@ PAD_NC(GPP_E06, NONE), /* GPP_E07 : net NC is not present in the given design */ PAD_NC(GPP_E07, NONE), - /* GPP_E08 : [] ==> SOC_GPP_E08 */ - PAD_NC(GPP_E08, NONE), + /* GPP_E08 : [] ==> USB_C0_AUX_DC_N */ + PAD_CFG_NF(GPP_E08, NONE, DEEP, NF6), /* GPP_E09 : [] ==> USB_C_OC_ODL */ PAD_CFG_NF_LOCK(GPP_E09, NONE, NF1, LOCK_CONFIG), /* GPP_E10 : net NC is not present in the given design */ @@ -226,8 +226,8 @@ PAD_NC(GPP_E16, NONE), /* GPP_E17 : net NC is not present in the given design */ PAD_NC(GPP_E17, NONE), - /* GPP_E22 : net NC is not present in the given design */ - PAD_NC(GPP_E22, NONE), + /* GPP_E22 : [] ==> USB_C0_AUX_DC_P */ + PAD_CFG_NF(GPP_E22, NONE, DEEP, NF6),
/* GPP_F00 : [] ==> CNV_BRI_DT_R */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_F00, NONE, DEEP, NF1),