Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak... File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36823/4/src/soc/amd/stoneyridge/Mak... PS4, Line 140: ifeq ($(CONFIG_SOC_AMD_MERLINFALCON),y) : : ifeq ($(CONFIG_HAVE_MERLINFALCON_BINARIES),y) : FIRMWARE_TYPE=CZ : else : FIRMWARE_TYPE=ST : endif
That is true, but unfortunately needed until binaries become available. […]
My point is this. If you add a patch that purports to solve a problem, but doesn't actually change the behavior, why have the patch at all? The first paragraph of your commit message sets the premise of ST binaries being built in if you don't possess MF binaries. Don't you still have that same problem with the way you've designed the logic above.