Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35158 )
Change subject: mb/google/hatch/var/helios: Increase touchscreen reset delay to 120ms
......................................................................
Patch Set 2:
Patch Set 2:
Would be nice if we had a way to control the report_en pin timing as well (requires >10ms after reset), GPP_H14.
Is that 120ms + 10ms after reset deasserted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id69a9db996bcd9001ef850c50898fbd55327b4df
Gerrit-Change-Number: 35158
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 15:28:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment