Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45227 )
Change subject: mb/google/dedede/var/magolor: Add touch screen devices
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45227/7/src/mainboard/google/dedede...
PS7, Line 104: register "hid_desc_reg_offset" = "0x01"
You will need disable_gpio_export_in_crs here as well. Only for ELAN0001 we don't need that.
done!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45227
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd2963317e858f7d35c937e45cd6f3e556bbb953
Gerrit-Change-Number: 45227
Gerrit-PatchSet: 8
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 06:31:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment