Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add and use it8528e
......................................................................
Patch Set 2:
Yeah, the whole IT85xx line seems to be ECs. We have some in
`ec/<possible firmware vendor>/it85*`. Their PnP interface seems
to be independent from the programmable part, though. So maybe
treating the interfaces separately would be feasible in this case.
We can't share the EC firmware interface parts ofc, but we could
share the PnP definitions. Though, if this is going to be another
driver that doesn't make this distinction (and gets firmware
interface parts added later), it should probably reside in `ec/`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72aa756e123d6f99d9ef4fe955c4b7f1be25d547
Gerrit-Change-Number: 30957
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 16 Jan 2019 15:23:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment