Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant. ......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... PS17, Line 22: gpio_table Can you please group and order this list in alphabetical order for GPP_*? It just makes it easy to find if a GPIO is configured here.
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... PS17, Line 100: early_gpio_table None of these GPIOs are configured in early_gpio_table[] in baseboard. Override logic just looks for a GPIO in baseboard and finds it in the override tree. So, this won't work.
It is probably better to just copy the early_gpio_table[] from baseboard and make the required changes here. Tim what do you think? We might have to add __weak for base_early_gpio_table in baseboard/gpio.c