Attention is currently required from: Angel Pons. Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51086 )
Change subject: mb/intel/shadowmountain: Add Cr50 support ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51086/comment/aefea88e_9360251f PS2, Line 7: sm
nit: I would not shorten `shadowmountain`
Done
File src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/51086/comment/ef484e9c_e9befcbb PS2, Line 26: H1_PCH_INT_ODL
Should these comments be updated?
the functionality remains same..just added a pull up