30 Oct
2020
30 Oct
'20
7:43 a.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46725 )
Change subject: sb/intel/lynxpoint/lpc.c: Simplify PM init sequence ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46725/12/src/southbridge/intel/lynx... File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/c/coreboot/+/46725/12/src/southbridge/intel/lynx... PS12, Line 336: RCBA32(0x3a80) = tbh I'm not sure if I like this way of setting registers... wouldn't it be better to introduce something like rcba32(reg, val) as we do with all other registers?
--
To view, visit https://review.coreboot.org/c/coreboot/+/46725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21e79cbc1e995707b87c40187ddf03b872d02058
Gerrit-Change-Number: 46725
Gerrit-PatchSet: 12
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 30 Oct 2020 06:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment