Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40298 )
Change subject: soc/amd/picasso: Notify PSP system is going to sleep state ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... File src/soc/amd/picasso/smihandler.c:
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... PS1, Line 148: slptyp
Done
N/A now. Have pushed CB:40338 and CB:40339
https://review.coreboot.org/c/coreboot/+/40298/1/src/soc/amd/picasso/smihand... PS1, Line 152: switch (slptyp) {
Given that `ACPI_Sx == x`, this looks odd. […]
It was intentional but I never quite liked it. We really need to ensure we're using the actual values and not enum'ed ones. This all goes away with CB:40338 and CB:40339 though.