Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph, Jeremy Soller, Christian Walter, Tim Wawrzynczak, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59887 )
Change subject: soc/intel/cannonlake: Hook up DPTF device to devicetree
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59887/comment/6188ddf3_b0e7757d
PS4, Line 204: device pci 04.0 on end # SA Thermal device
I would prefer separate changes for devices that had it `off` by accident.
This will change coreboot's behavior, for instance if the allocator handles
the device, if PCI drivers will be run (couldn't find one, but in soc/intel/
it's not easy to find anything) etc.
File src/mainboard/system76/bonw14/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/59887/comment/60a9866b_4539b937
PS4, Line 72: device pci 04.0 off end # SA Thermal device
Looks like it was my mistake when upstreaming the board, forgetting the FSP config.
Do you mean the intention was to enable it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2ab7a691cb0f6941ef7c9def5fa2e6247127c15
Gerrit-Change-Number: 59887
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 11 Dec 2021 11:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Crawford
tcrawford@system76.com
Gerrit-MessageType: comment