[coreboot-gerrit] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Use tlcl_get_hash_size_from_algo() for hash...

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33251 )

Change subject: security/tpm/tss/tcg-2.0: Use tlcl_get_hash_size_from_algo() for hash size
......................................................................

Patch Set 4:

(1 comment)

oh, just found a possible problem right after merging this patch... it shouldn't hit that code path at the moment, but I'd really appreciate this being fixed before it will cause problems (only out of bounds read and not an out of bounds write; if it was the latter, I'd have reverted this patch)

https://review.coreboot.org/c/coreboot/+/33251/4/src/security/tpm/tss/tcg-2.... 
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:

https://review.coreboot.org/c/coreboot/+/33251/4/src/security/tpm/tss/tcg-2.... 
PS4, Line 86: tpmtha->digest.sha256
this should also be replaced, so you don't get an out-of-bounds access when selecting e.q. sha512