Attention is currently required from: Jamie Chen, shkim, SH Kim, Karthik Ramasubramanian.
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49791 )
Change subject: mb/google/dedede/var/sasuke: Configure GPP_G7 as native
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/dedede/variants/sasuke/gpio.c:
https://review.coreboot.org/c/coreboot/+/49791/comment/8cac824d_98b80826
PS2, Line 52: PAD_NC(GPP_G7, NONE),
Ping Jemie@Intel. Thanks.
Put my comment on the tracker.
It's better to change back to NF. Because we use the FSP dll settings for SD bus and these settings have been tuned on RVP with standard SD slot.
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If73337b482f04fd263caaa6fed0e54aa87bd876e
Gerrit-Change-Number: 49791
Gerrit-PatchSet: 2
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:02:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment