[coreboot-gerrit] Change in ...coreboot[master]: drivers/wifi: Add generic WiFi driver

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33155 )

Change subject: drivers/wifi: Add generic WiFi driver
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c 
File src/drivers/wifi/generic.c:

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@195 
PS4, Line 195: )
> See patchset #3.

Okay. Makes sense. I was just worried that there might be some device which uses wake = 0 to indicate no wake from wifi. But from a quick grep, it doesn't look like there is any such device in coreboot.

https://review.coreboot.org/#/c/33155/4/src/drivers/wifi/generic.c@230 
PS4, Line 230: const char *generic_wifi_acpi_name(const struct device *dev)
> I guess the worst thing that happens is ACPI interpreter throws more runtime errors in kernel logs o […]

It would be a violation only if the same name appears under the same namescope and path. I am fine either ways -- doing it now or later when there really is a need for it.