7 Mar
2019
7 Mar
'19
9:30 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31801 )
Change subject: mainboard/sarien: Save the Cr50 recovery switch state in VBNV ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31801/1/src/mainboard/google/sarien/chromeos... File src/mainboard/google/sarien/chromeos.c:
https://review.coreboot.org/#/c/31801/1/src/mainboard/google/sarien/chromeos... PS1, Line 90: !ENV_VERSTAGE I am a bit confused by this check. If this is VERSTAGE and you end up reading the recovery switch second time, then it still queries cr50. Wouldn't that return incorrect value since it is read one-time?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31801
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadf0cec651b3a26ceebadfeb637e189805c328bf
Gerrit-Change-Number: 31801
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Keith Short keithshort@chromium.org
Gerrit-Reviewer: Stefan Reinauer reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 07 Mar 2019 20:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment