Matthew Garrett has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32530
Change subject: Fix fsp post-init validation ......................................................................
Fix fsp post-init validation
Part of this checks whether tolum_base and cbmem_top are the same - however, cbmem_top hasn't been initialised at the point where this call occurs. Change the ordering to fix that.
Signed-off-by: Matthew Garrett mjg59@google.com Change-Id: Ib89e0513bdc35c3751a9d4c2a2789a2836046789 --- M src/drivers/intel/fsp2_0/memory_init.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/32530/1
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c index 985ee3a..e021f52 100644 --- a/src/drivers/intel/fsp2_0/memory_init.c +++ b/src/drivers/intel/fsp2_0/memory_init.c @@ -310,8 +310,6 @@ post_code(POST_FSP_MEMORY_EXIT); timestamp_add_now(TS_FSP_MEMORY_INIT_END);
- fsp_debug_after_memory_init(status); - /* Handle any errors returned by FspMemoryInit */ fsp_handle_reset(status); if (status != FSP_SUCCESS) { @@ -320,6 +318,8 @@ }
do_fsp_post_memory_init(s3wake, fsp_version); + + fsp_debug_after_memory_init(status); }
/* Load the binary into the memory specified by the info header. */