Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39890 )
Change subject: mb/google/glados: remove Chrome-EC defaults ......................................................................
mb/google/glados: remove Chrome-EC defaults
Chrome-EC/PD images for all glados variants need to be built from the board-specific branch, not master. Including the default board names serves no purpose and requires users to deselect the "use built-in EC firmware" in order for the board to build.
Test: build google/chell with defaults
Change-Id: Ic10f11337b85035068cdc4fe8147413e6b7f57ac Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39890 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/Kconfig 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index bc0c67b..c90b2bd 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -77,18 +77,6 @@ select NHLT_DMIC_2CH select NHLT_NAU88L25
-config EC_GOOGLE_CHROMEEC_BOARDNAME - string - default "chell" if BOARD_GOOGLE_CHELL - default "glados" if BOARD_GOOGLE_GLADOS - default "" - -config EC_GOOGLE_CHROMEEC_PD_BOARDNAME - string - default "chell_pd" if BOARD_GOOGLE_CHELL - default "glados_pd" if BOARD_GOOGLE_GLADOS - default "" - config UART_FOR_CONSOLE int default 2