Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33839/8/Documentation/mainboard/pro...
File Documentation/mainboard/protectli/fw6.jpg:
PS8:
Would it be possible to have a picture of the internals instead?
Yes, I guess
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau...
File src/mainboard/protectli/vault_kbl/Kconfig:
https://review.coreboot.org/c/coreboot/+/33839/8/src/mainboard/protectli/vau...
PS8, Line 46: config INTEL_GMA_VBT_FILE
Isn't that the default path?
Unfortunately not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03e8e8db5d827fe113280f2a6376d364edf42870
Gerrit-Change-Number: 33839
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 11:45:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment