Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35753 )
Change subject: sb/intel/ibexpeak: Implement PCH function disable in chip_ops ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... PS7, Line 498: switch (pch_silicon_type()) { So.. this is just upper byte of PCI device ID?
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... PS7, Line 815: static const unsigned short pci_device_ids[] = { 0x3b07, 0x3b09, 0 }; src/southbridge/intel/ibexpeak/pch.h:#define PCH_TYPE_MOBILE5 0x3b
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/pch.c:
https://review.coreboot.org/c/coreboot/+/35753/7/src/southbridge/intel/ibexp... PS7, Line 36: if (pch_type < 0) : pch_type = pci_read_config8(dev, PCI_DEVICE_ID + 1); : return pch_type;
It's still there on the latest patchset. […]
And that callsite is spurious unless different PCI device IDs are added to lpc.c. If you remove that, we don't need this at all.