3 comments:
File src/southbridge/intel/ibexpeak/lpc.c:
Patch Set #7, Line 498: switch (pch_silicon_type()) {
So.. this is just upper byte of PCI device ID?
Patch Set #7, Line 815: static const unsigned short pci_device_ids[] = { 0x3b07, 0x3b09, 0 };
src/southbridge/intel/ibexpeak/pch.h:#define PCH_TYPE_MOBILE5 0x3b
File src/southbridge/intel/ibexpeak/pch.c:
if (pch_type < 0)
pch_type = pci_read_config8(dev, PCI_DEVICE_ID + 1);
return pch_type;
> It's still there on the latest patchset. […]
And that callsite is spurious unless different PCI device IDs are added to lpc.c. If you remove that, we don't need this at all.
To view, visit change 35753. To unsubscribe, or for help writing mail filters, visit settings.