Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37228 )
Change subject: vc/amd/pi: Allow 00670F00 to build with no binaryPI
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670...
File src/vendorcode/amd/pi/00670F00/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670...
PS1, Line 122: unlikely
impossible?
From my understanding, this is a temporary step. Some builds in the patch stack will be build without AGESA or even some blobs. Part of a transition to a new blobs location. This will not be the final code, and I suspect Marshall will remove this at the very end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37228
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74a38efa2a4ad2f9f12a1f8e7fb8694d0ab9dd1e
Gerrit-Change-Number: 37228
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 Nov 2019 17:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment