[coreboot-gerrit] [S] Change in coreboot[main]: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB

[Bill XIE (Code Review)]

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Martin L Roth, Matt DeVillier, Nico Huber, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh.

Hello Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Matt DeVillier, Nico Huber, Patrick Georgi, Paul Menzel, Subrata Banik, Werner Zeh, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/78623?usp=email

to look at the new patch set (#13).

Change subject: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
......................................................................

Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB

Commit 44a48ce7a46c ("Kconfig: Bring HEAP_SIZE to a common, large
value") breaks S3 resume from TSEG stage cache on many platforms,
including GM45 and Ivy Bridge, so limit it to 512 KiB.

HEAP_SIZE overrides greater than 512K prior to commit 44a48ce7a46c are
restored.

Please test this against other platforms before merging!

Tested: Setting it to 0x80000 results a working S3 resume on Thinkpad
    X200 and T430, with log in cbmem for S3 resume, while 0xa0000
    breaks it. coreboot log during failed resume when (HEAP_SIZE
    >= 0xa0000) cannot be obtained from EHCI debug, while log in
    cbmem shows that ramstage is failed to be found in TSEG stage
    cache, as shown in https://ticket.coreboot.org/issues/512 .

Resolves: https://ticket.coreboot.org/issues/512
Signed-off-by: Bill XIE 
Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
---
M src/Kconfig
M src/northbridge/amd/pi/Kconfig
M src/soc/amd/picasso/Kconfig
M src/soc/amd/stoneyridge/Kconfig
4 files changed, 14 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/78623/13