Attention is currently required from: Hung-Te Lin.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )
Change subject: util: cbfstool: Check alignment at build time
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
Let's try to follow up again. […]
1, 2 or 3 all sound fine to me. I would not prefer 4 because I think that hurts readability by cluttering the FMD file with too much noise.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 11
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 14 Jun 2023 02:34:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment