
Attention is currently required from: Angel Pons, xin hua wang, Nicholas Chin. Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 ) Change subject: mb/apple: Add MacBook Pro 8,1 support ...................................................................... Patch Set 18: (2 comments) Patchset: PS16:
I've emailed Evgeny about taking over this patch, and he says he doesn't have time to work on it and […] I still have all of these systems and can do occasional testing, so don't hesitate to ping me if you need to test something. (But not at the moment, as they are ~2000 km away from me and we have a war situation that complicates everything).
File src/mainboard/apple/macbookpro8_1/mainboard.c: https://review.coreboot.org/c/coreboot/+/33151/comment/b3e1a087_d312dd3d PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, : GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
If this port hasn't been tested with an Intel VGA BIOS and without SeaBIOS, I'd drop the entire file […] This particular wasn't, but I tested VGA BIOS on MBP 10,1 and MBA 5,2.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33151 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2 Gerrit-Change-Number: 33151 Gerrit-PatchSet: 18 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-CC: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: xin hua wang <xinhuawang0101@gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 21:48:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-MessageType: comment