chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44135 )
Change subject: mb/google/zork: keep the c-state IO base address alignment
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44135/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44135/3//COMMIT_MSG@7
PS3, Line 7: mb/google/zork: C-state IO base address alignment
Please make this a statement by adding a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/cpu.c
File src/soc/amd/picasso/cpu.c:
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/cpu.c@5...
PS4, Line 56:
Remove blank line
Done
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/44135/4/src/soc/amd/picasso/include...
PS4, Line 72: 0x0c
to my other comment: change this to 0x13 to align things with the AGESA side and don't introduce CON […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib98d34af518439d338326446c20601867ad31690
Gerrit-Change-Number: 44135
Gerrit-PatchSet: 6
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Aug 2020 06:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment