Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Naresh Solanki, Patrick Rudolph, Paul Menzel.
Maximilian Brune has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................
Patch Set 4:
(2 comments)
File src/soc/amd/glinda/cpu.c:
https://review.coreboot.org/c/coreboot/+/85640/comment/d834717d_22715c9e?usp... :
PS4, Line 39: s
maybe add a comment like: `get local APIC ID` at the end of the line.
That begs the question if we should use one of the existing functions (e.g. `lapicid()`) to get this information?
https://review.coreboot.org/c/coreboot/+/85640/comment/1feaa30c_d15cf0e2?usp... :
PS4, Line 41: __fls(info->num_cores_shared-1);
it may make sense to use `log2` directly, since that is also what is used in the AMD64 specification.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6
Gerrit-Change-Number: 85640
Gerrit-PatchSet: 4
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Feb 2025 15:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No