[coreboot-gerrit] [M] Change in coreboot[main]: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper

[Maximilian Brune (Code Review)]

Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Naresh Solanki, Patrick Rudolph, Paul Menzel.

Maximilian Brune has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )

Change subject: soc/amd/glinda/cpu: Implement soc_fill_cpu_cache_info helper
......................................................................

Patch Set 4:

(2 comments)

File src/soc/amd/glinda/cpu.c:

https://review.coreboot.org/c/coreboot/+/85640/comment/d834717d_22715c9e?usp... :
PS4, Line 39: 	s
maybe add a comment like: `get local APIC ID` at the end of the line.
That begs the question if we should use one of the existing functions (e.g. `lapicid()`) to get this information?

https://review.coreboot.org/c/coreboot/+/85640/comment/1feaa30c_d15cf0e2?usp... :
PS4, Line 41: __fls(info->num_cores_shared-1);
it may make sense to use `log2` directly, since that is also what is used in the AMD64 specification.