28 Apr
2020
28 Apr
'20
2:32 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40541 )
Change subject: mb/facebook/watson: Make watson as a variant ......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Just a minor nit, otherwise this seems fine to me.
https://review.coreboot.org/c/coreboot/+/40541/5/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/40541/5/src/mainboard/facebook/wats... PS5, Line 2: Watson: 1st variant of Watson microserver A short name will suffice here, otherwise `menuconfig` looks cluttered... maybe just Watson_v1?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40541
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I1164ee9f8d07cebf8d505ca1e164823c1cb5625c
Gerrit-Change-Number: 40541
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen rgzwen@arista.com
Gerrit-Reviewer: Wei Hu wei@arista.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 02:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment