Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49470 )
Change subject: soc/intel/common/graphics: Add new Kconfig SOC_INTEL_DISABLE_IGD ......................................................................
Patch Set 2:
(4 comments)
Patchset:
PS2:
I left some comments, but will stop from now on unless you provide […]
Added details in commit msg, please check
File src/soc/intel/common/block/graphics/Kconfig:
https://review.coreboot.org/c/coreboot/+/49470/comment/976f1fbd_3cde6afb PS2, Line 12: bool
I think it should have a prompt so the user can decide. That's what I […]
Done
https://review.coreboot.org/c/coreboot/+/49470/comment/c6fc320a_dc33c982 PS2, Line 15: platforms
What does "platform" mean in this context? […]
replace with motherboard
https://review.coreboot.org/c/coreboot/+/49470/comment/0e49be22_c01bed4f PS2, Line 15: Selected by platforms that need to skip IGD initialization : for various reasons like platform having discrete PCIe GFX : VGA card for graphics initialization and SoC don't need to : run FSP GOP.
I can't say that I really understand it. […]
added that too