Hello Kyösti Mälkki, Aaron Durbin, Patrick Rudolph, Julius Werner, Michael Niewöhner, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36140
to look at the new patch set (#2).
Change subject: [POC,RFC] Pass cbmem_top from romstage to relocatable stages param ......................................................................
[POC,RFC] Pass cbmem_top from romstage to relocatable stages param
Currently all stages that need cbmem need an implementation of a cbmem_top function. On FSP and AGESA platforms this proves to be painful and using the top of lower memory if often passed via lower memory or via a PCI scratchpad register.
The problem with writing to lower memory is that also need to be written on S3 as one cannot assume it to be still there. Writing things on S3 is always a fragile thing to do.
A better and more generic solution is to pass along cbmem_top via relocatable module parameters.
TODO: other platforms, nb/intel/i945 only at the moment.
Tested on Thinkpad X60.
Change-Id: I3195560f110720959fd7389b366d001bfde4da05 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/Makefile.inc M src/arch/x86/c_start.S A src/arch/x86/cbmem_top.c M src/arch/x86/exit_car.S M src/arch/x86/postcar_loader.c M src/lib/prog_loaders.c M src/lib/program.ld M src/northbridge/intel/i945/memmap.c 8 files changed, 64 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/36140/2