Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30999 )
Change subject: mainboard/google/kahlee: Configure debounce settings for interrupt GPIOs
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30999/1/src/mainboard/google/kahlee/variants...
File src/mainboard/google/kahlee/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30999/1/src/mainboard/google/kahlee/variants...
PS1, Line 122: /* GPIO_9 - H1_PCH_INT_ODL, SCI */
Might want a comment here that it's needed in reset for new systems and ram for existing systems. Or not. Up to you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30999
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1bd269c196ca9b48157e177fd5834e2f5d5703a
Gerrit-Change-Number: 30999
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Jan 2019 18:41:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment