Attention is currently required from: Werner Zeh. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )
Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: The implementation looks good. However TBH, I would prefer a separate driver under fast_spi/. This file is already used as a dump for random things with SPI in its name, AFAICS. The fast_spi controllers are not useful for generic SPI slaves but only for NOR flash and TPMs and abs- tract all SPI details in both cases. While the original purpose of this driver seems to be to handle generic SPI slaves.
File src/soc/intel/common/block/spi/spi.c:
https://review.coreboot.org/c/coreboot/+/63982/comment/418636c0_fea4038e PS1, Line 192: .acpi_hid = spi_acpi_hid, : .acpi_name = spi_acpi_name, Technically, these two hooks are only useful if another driver generates the ACPI code and needs to call these for an abstract device pointer. With the local .acpi_fill_ssdt implementation, we know what device we have anyway.