HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31139 )
Change subject: lib/hardwaremain: Fix typo ACPI
......................................................................
Patch Set 2:
same typo here, isn't it ?
src/include/nhlt.h:57
https://review.coreboot.org/#/c/coreboot/+/31152/
src/mainboard/hp/dl165_g6_fam10/romstage.c:200
I don;t see any ACPI error here ?
"//do we need apci timer, tsc...., only debug need it for better
output"
shouldn't be :
//do we need ACPI ....
Ahh, u r right. updated
one more ?:
nano +169 src/southbridge/broadcom/bcm5785/early_setup.c : "// ioapci enable"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51493203b82868d221806c2e22b0c4b62e9fac97
Gerrit-Change-Number: 31139
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 30 Jan 2019 10:05:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment