Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59551 )
Change subject: drivers/i2c/tpm: Fix blank default statement ......................................................................
drivers/i2c/tpm: Fix blank default statement
CB:59479 introduced a blank default statement. This is treated as an error or warning on some older toolchains. Add a break statement on default case.
BUG=None TEST=Build the Guybrush mainboard.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I3d034cfebc8b8ae7d7024d41b4b2207cdeb083e8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59551 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Patrick Georgi patrick@coreboot.org Reviewed-by: Rob Barnes robbarnes@google.com --- M src/drivers/i2c/tpm/chip.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Raul Rangel: Looks good to me, approved Rob Barnes: Looks good to me, approved
diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c index 3a2f8aa..07052f6 100644 --- a/src/drivers/i2c/tpm/chip.c +++ b/src/drivers/i2c/tpm/chip.c @@ -60,6 +60,7 @@ case TPM_DEFAULT_POWER_MANAGED: default: /* Leave firmware-power-managed unset */ + break; } acpi_dp_write(dsd);